search

arpadHegedus / postcss-node-sass

A PostCSS plugin to parse styles with node-sass
MIT License
23 stars 16 forks source link

Combine efforts? #1

Closed jonathantneal closed 6 years ago

jonathantneal commented 6 years ago

Hi @arpadHegedus,

I went to publish a similar module and saw your excellent work. Would you be interested in absorbing the work I’ve done?

https://github.com/jonathantneal/postcss-node-sass/#readme

Here are 3 key additions:

  1. Support for passing Node Sass options via PostCSS Node Sass.
  2. Preservation of source maps from Node Sass, as well as any PostCSS plugins run before it.
  3. Feature tests, Node 4.x compatibility, automated tests for both Windows and *Nix environments.
arpadHegedus commented 6 years ago

Awesome. Thank you. I'll double check everything and will merge your code.

EDIT: I've checked your code and will merge some ideas and these features in the next couple of days. I hope this is all right with you. I don't want to simply merge your pull request as it completely overwrites my plugin and I want to keep it very, very simple.

jonathantneal commented 6 years ago

@arpadHegedus, thanks for checking this out! If there are ways to make it more simple, go for it. What kinds of things do you want simplified? Can I help? 😄

What was important to me was not adding any options (just forwarding them from the plugin) and preserving source maps. Right now, my company is using things like postcss-import before node-sass, so losing all the file references was making debugging too rough, and sass does not respect imported sourcemaps (reference).

As for all the tests, it’s a quality requirement of PostCSS plugins (@ai could get into more detail), but it’s just good practice for any node module, as it also protects me against accidental breaking changes.

jonathantneal commented 6 years ago

@arpadHegedus, how goes the review?

arpadHegedus commented 6 years ago

I've merged some of your suggestions from #2

Thank you, @jonathantneal