arpcard / aro

The Antibiotic Resistance Ontology (ARO) organizes the information describing the ability of a microorganism to withstand the effects of an antibiotic
Creative Commons Attribution 4.0 International
16 stars 6 forks source link

Normalize PubChem compound references #6

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

PubChem is an ambiguous prefix that could refer to one of the several semantic spaces. This PR updates them to use a more standardized prefix based on the Bioregistry's standard. While PRs are normally made to the -edit file, it looks like this one is out of sync, so I made the changes in all of the artifacts. Would be worth looking into properly reconciling all of the artifacts in this repo as well.

cthoyt commented 2 years ago

@raphenya @arpcard @agmcarthur can anyone take a look at this?

agmcarthur commented 2 years ago

Thanks @cthoyt! This repo is a bit odd in that the ARO is only updated at the CARD website by the curators (we have a custom interface) and then the updates pushed to here. As such, I will reject the merge here but instead pass on all the information for curators to review and then add to the ARO. I'll create an issue to track our progress.

cthoyt commented 2 years ago

@agmcarthur that seems a bit problematic, considering the front page says to look at the editor's version of the ontology at https://github.com/arpcard/aro#editors-version. Does this mean it's not possible for this ontology to accept external contributions?