search

arpg / HAL

Hardware Abstraction Layer library.
Other
36 stars 24 forks source link

Ximea drivers link against -lusb-1.0, not fully qualified name #145

Closed crheckman closed 6 years ago

crheckman commented 6 years ago

This causes an issue with the custom-shipped Ximea driver for libusb; it needs to be explicitly provided (this required a manual rewrite in link.txt for the fully qualified name). This should be addressed at the cmake level (I think the problem is in the HAL linker line).

crheckman commented 6 years ago

Tried one fix in the fix/custom_lusb_linker branch to try and remove what I believe is just the linker pollution in this library. @mkaspr give it a shot? @ckenwood maybe you can try too?

ckenwood commented 6 years ago

Still getting the libusb error with this branch checked out on the laptop we were working on but HAL and dependent libraries build fine from this branch and from master on the computer we got for the Husky. Seems like some linkage is just messed up on that laptop, may not be a HAL issue.

crheckman commented 6 years ago

Solution for now is to run find . -type f -exec sed -i 's/\-lusb/\/lib\/libusb\-1\.0\.so/g' {} + if in Linux (BSD requires '' after the . due to differences in sed). Since this is only present on @ckenwood 's side I am going to close and delete the branch.