arpit456jain / Amazing-Js-Projects

Amazing-Js-Projects

https://amazing-js-project.netlify.app/

MIT License

146 stars 213 forks source link

Spotify bug #584

Closed mayank-del closed 2 years ago

mayank-del commented 2 years ago

Fixes: #571

Description:

Actually in spotify, icon tag whose className was songItemPlay was only capable of playing a song , but it should also pause the song when user click it again, but that functionality was not there. So, I added that functionality too. Now, it will do both play and pause whenever user will click on it.

Type of change

[ x] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)

Checklist:

[x ] I have made this from my own
[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[ x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

netlify[bot] commented 2 years ago

Deploy Preview for amazing-js-projects ready!

Name	Link
Latest commit	2b65dcc452ec89de584261359fb57f7dd93466d2
Latest deploy log	https://app.netlify.com/sites/amazing-js-projects/deploys/6273bcce159a2b0008f9a514
Deploy Preview	https://deploy-preview-584--amazing-js-projects.netlify.app/spotify clone
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @mayank-del :)

mayank-del commented 2 years ago

Please add the index.html file in this PR so that I can verify the changes

@VidhiBhatt01 maam ,i only changed the functionalities of scripts.js file, so only that file came in pr. i only fixed the bugs of buttons, you can check in the pr as well

VidhiBhatt01 commented 2 years ago

Please add the index.html file in this PR so that I can verify the changes

@VidhiBhatt01 maam ,i only changed the functionalities of scripts.js file, so only that file came in pr. i only fixed the bugs of buttons, you can check in the pr as well

I get you but you still need to attach the index.html file with this PR without that I cannot verify the changes

mayank-del commented 2 years ago

@VidhiBhatt01 maam ,I have attached index.html by a new commit, please check

arpit456jain commented 2 years ago

remove the changes from HTML file and add a comment in it it will be enough to check it

mayank-del commented 2 years ago

remove the changes from HTML file and add a comment in it it will be enough to check it

Ok sir, thanks for helping, i will surely do that thing.

arpit456jain / Amazing-Js-Projects

Spotify bug #584

Type of change

Checklist:

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

✅ Deploy Preview for amazing-js-projects ready!

Deploy Preview for amazing-js-projects ready!