arpit456jain / Amazing-Js-Projects

Amazing-Js-Projects
https://amazing-js-project.netlify.app/
MIT License
146 stars 213 forks source link

Age Calculator presentation issue resolved #606

Closed Qamberhasnain closed 2 years ago

Qamberhasnain commented 2 years ago

Description

As it can be seen in the screenshot that it shows only numbers after calculation in the boxes of Years, Months and Days. It seems odd that only numbers are written their without any unit. It can be seen in the screenshot that it shows font size and color of output is oddly white and big.

Fixes: #591

Type of change

Checklist:

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Before changes

image

After changes

image

netlify[bot] commented 2 years ago

Deploy Preview for amazing-js-projects ready!

Name Link
Latest commit 360415189bf1a1ec7b67cf94b4511e19df792c19
Latest deploy log https://app.netlify.com/sites/amazing-js-projects/deploys/627140f589cce10009c54893
Deploy Preview https://deploy-preview-606--amazing-js-projects.netlify.app/age calculator
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @Qamberhasnain :)

Qamberhasnain commented 2 years ago

As the deployment link is broken because of the space between age and calculator. So either you can copy whole URL and see the deployed patch or you can click here.

Qamberhasnain commented 2 years ago

https://deploy-preview-606--amazing-js-projects.netlify.app/age%20calculator/

Awesome! Thanks for improving the template

Thank you for saying that @VidhiBhatt01

Qamberhasnain commented 2 years ago

@VidhiBhatt01 Can I be a collaborator on this project?

github-actions[bot] commented 2 years ago

Thank you @Qamberhasnain for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)