arpit456jain / Amazing-Js-Projects

Amazing-Js-Projects
https://amazing-js-project.netlify.app/
MIT License
146 stars 213 forks source link

spotify-bug fix #622

Closed mayank-del closed 2 years ago

mayank-del commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #571

Type of change

Checklist:

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

netlify[bot] commented 2 years ago

Deploy Preview for amazing-js-projects ready!

Name Link
Latest commit 155d3024f215bc88f295b2a1df7d100f423618bd
Latest deploy log https://app.netlify.com/sites/amazing-js-projects/deploys/6277bd86a49b980008797daa
Deploy Preview https://deploy-preview-622--amazing-js-projects.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @mayank-del :)

mayank-del commented 2 years ago

@VidhiBhatt01 maam ,I removed the previous pr and added this pr , it fulfills every condition told by you.

VidhiBhatt01 commented 2 years ago

https://deploy-preview-622--amazing-js-projects.netlify.app/spotify%20clone/

mayank-del commented 2 years ago

Everything is perfect, except the responsiveness. You wanna fix it or shall I create a new issue for that? image

Just merge it, I will create that issue and fix it in the shortest possible time.

mayank-del commented 2 years ago

@VidhiBhatt01 maam, merge it, i will make it responsive responsive the next issue in which i am assigned by you.

arpit456jain commented 2 years ago

@mayank-del make it responsive in this PR no need to make another

mayank-del commented 2 years ago

@arpit456jain sir , I made it responsive for less than 300px, just check it and please make it level 3

Screenshot (6)

mayank-del commented 2 years ago

@DEEPALI-SUK , please check it now, I have added everything told by you, now please make it level 3.

mayank-del commented 2 years ago

@VidhiBhatt01 maam , @DEEPALI-SUK maam and @arpit456jain sir, I added everything , now merge it and please make it level 3 for responsiveness issue fixed.

DEEPALI-SUK commented 2 years ago

@VidhiBhatt01 maam , @DEEPALI-SUK maam and @arpit456jain sir, I added everything , now merge it and please make it level 3 for responsiveness issue fixed.

@arpit456jain

github-actions[bot] commented 2 years ago

Thank you @mayank-del for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)