Closed mayank-del closed 2 years ago
Name | Link |
---|---|
Latest commit | 3974aadc490de96a5effbb88cd2e907da3396723 |
Latest deploy log | https://app.netlify.com/sites/amazing-js-projects/deploys/6277bf50858f7900096eb089 |
Deploy Preview | https://deploy-preview-623--amazing-js-projects.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Our team will soon review your PR. Thanks @mayank-del :)
@VidhiBhatt01 maam , This is the a new fresh PR contains everything you told.
Should I have to make it responsive also, since this todo app was not responsive from beginning , if I will do that extra work , will I get extra point for that work or should I create new issue for responsiveness??
https://deploy-preview-623--amazing-js-projects.netlify.app/todo%20app/
You can create a new issue and make it responsive. Allowing to create a new issue as the template was not responsive from earlier
Ok maam then, merge it ,I am creating a new issue for that.
@VidhiBhatt01 maam, merge it, i will make it responsive in #625 issue in which i am assigned by you
@mayank-del make it responsive in this PR itself
@mayank-del make it responsive in this PR itself
Actually, I am just asking that , if I will make it responsive in this PR, then i will get extra points or not?
Because , In this issue , i have to add only editing feature, i made it, but for making it responsive, i should get some more points na sir, so that my rank would little bit more up
If that will be the case , then making responsive in this PR will be more convenient for me.
@mayank-del make it responsive in this PR itself
Actually, I am just asking that , if I will make it responsive in this PR, then i will get extra points or not?
Because , In this issue , i have to add only editing feature, i made it, but for making it responsive, i should get some more points na sir, so that my rank would little bit more up
If that will be the case , then making responsive in this PR will be more convenient for me.
@arpit456jain , @VidhiBhatt01 ,please clarify this doubt of mine , please, I don't know about points distribution system of gssoc , so please help me with this doubt.
@mayank-del yes u will get lvl 3
@arpit456jain sir , I made it responsive, Please check it
@VidhiBhatt01 check for the responsiveness
@VidhiBhatt01 maam and @DEEPALI-SUK , what happened ?
I added everything, please check it
- delete extra folders and files
- still not responsive
- add in the style_links.json file of the main repo, do not make ur own
maam , in phone it is responsive , but it's initial state comes as zoom-in, so just zoom-out it,then, you will see it's original look
Why Spotify Clone folder is there
update ur branch
Why Spotify Clone folder is there
Maam, I deleted those folders, but @arpit456jain told to add those back again, otherwise, they will be lost so i have to commit them inside this folder again.You can see previous comments also
Why Spotify Clone folder is there
update ur branch
Update means???
@mayank-del update ur branch and add folder again and make a fresh PR
Thank you @mayank-del for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #570
Type of change
Checklist:
ATTACH SCREEN-SHOTS / DEPLOYMENT LINK