arpit456jain / Amazing-Js-Projects

Amazing-Js-Projects
https://amazing-js-project.netlify.app/
MIT License
146 stars 213 forks source link

Colorpicker #631

Closed DragonUncaged closed 2 years ago

DragonUncaged commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #621

Type of change

Checklist:

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

netlify[bot] commented 2 years ago

Deploy Preview for amazing-js-projects ready!

Name Link
Latest commit 0249e368e8eb6d99859b5813ebece37b9ba21bfd
Latest deploy log https://app.netlify.com/sites/amazing-js-projects/deploys/627936a64070b70008aa91ba
Deploy Preview https://deploy-preview-631--amazing-js-projects.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @DragonUncaged :)

astha2412 commented 2 years ago

@DragonUncaged Add preview.png

astha2412 commented 2 years ago

Screenshot (438)_LI Correct the file name

DragonUncaged commented 2 years ago

@DragonUncaged Add preview.png

already added preview.jpg

DragonUncaged commented 2 years ago

In mobile view I am not able to pick colors

Drag and drop does not work with touch event/ touch screen devices. That's Why

I have learned this From. Mozilla website For the Drag Event in JavaScript And it does Not work in their Website also You Can see. image

DEEPALI-SUK commented 2 years ago

@arpit456jain what we have to do for mobile view?

arpit456jain commented 2 years ago

@DragonUncaged add all colors why its only shades of red ? and resolve merge conflicts

github-actions[bot] commented 2 years ago

Thank you @DragonUncaged for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)