arpit456jain / Amazing-Js-Projects

Amazing-Js-Projects
https://amazing-js-project.netlify.app/
MIT License
146 stars 213 forks source link

modified: Styles changed #663

Closed BIKRAM-SAHA closed 2 years ago

BIKRAM-SAHA commented 2 years ago

Description

Suggested changes on the issue page were made

Fixes: #657

Type of change

Checklist:

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

BEFORE: image

AFTER: image

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @BIKRAM-SAHA :)

netlify[bot] commented 2 years ago

Deploy Preview for amazing-js-projects ready!

Name Link
Latest commit 1073b6484c008cf556191e4c00f72127fce9ef48
Latest deploy log https://app.netlify.com/sites/amazing-js-projects/deploys/62832e96f4973f00095fa8a4
Deploy Preview https://deploy-preview-663--amazing-js-projects.netlify.app/birthday countdown
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

BIKRAM-SAHA commented 2 years ago

Can you add before after image? Also, you need to attach the index.html file along with this PR. then and only then I will be able to verify the changes

@VidhiBhatt01

  1. I have updated the PR message with the before and after messages.
  2. Sorry but I didnt get that. How will I attach the index.html file with the PR? I think I have to make some changes in index.html and commit then only it will show up along the commits in the PR. Is there anything u want to be changed in the index.html file.
  3. If you just wish to have the index.html for verifying if the changes worked out ig you can use the Deploy Preview link from the netlify bot :

Deploy Preview for amazing-js-projects ready!

Name Link Latest commit 36b2930 Latest deploy log https://app.netlify.com/sites/amazing-js-projects/deploys/627e31210f377b0008b6a0e6 Deploy Preview https://deploy-preview-663--amazing-js-projects.netlify.app Preview on mobile
Toggle QR Code... To edit notification comments on pull requests, go to your Netlify site settings.

  1. Also I noticed, the previous contributor forgot to remove console.log() statements from the project. Should I remove them or let it be?
BIKRAM-SAHA commented 2 years ago

@VidhiBhatt01 Done with the changes. Is there anything else to do?

github-actions[bot] commented 2 years ago

Thank you @BIKRAM-SAHA for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)