arpit456jain / Cool-Front-End-Templates

https://cool-frontend-templates.netlify.app/
MIT License
222 stars 319 forks source link

Added Email Authentication Method #812

Closed Abh1shekSingh closed 2 years ago

Abh1shekSingh commented 2 years ago

Description

I have added Email Authentication method. I have attached screenshot for your Reference. User can signup wit his email an password and then if he came later he can use the same id password to login back. Its also display the name or email, depends what he has in the json, on the top of screen.

Fixes: #811

Checklist:

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

after succes signup after success login with same idpsd firebase

netlify[bot] commented 2 years ago

Deploy Preview for cool-front-end-templates ready!

Name Link
Latest commit 00158d687abc1760d26dc52204ff76229639f124
Latest deploy log https://app.netlify.com/sites/cool-front-end-templates/deploys/627fa4acbed86e000808ee21
Deploy Preview https://deploy-preview-812--cool-front-end-templates.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @Abh1shekSingh :)

Abh1shekSingh commented 2 years ago

@VidhiBhatt01 @astha2412 @DEEPIKA-SUK Please review my PR HERE IS THE DEPOLYED LINK : https://deploy-preview-812--cool-front-end-templates.netlify.app/login%20form/

The one provided by github is wrong

Abh1shekSingh commented 2 years ago

@Abh1shekSingh after login also it is showing welcome username in the same login page. So add one more page for welcome or disable that login form after login.

My job was to add authentication only. and display the name. but if ur saying i will do that

DEEPIKA-SUK commented 2 years ago

@Abh1shekSingh after login also it is showing welcome username in the same login page. So add one more page for welcome or disable that login form after login.

My job was to add authentication only. and display the name.

@Abh1shekSingh because of this login form the person can login multiple times even they are already logged in. So disable login button or hide this login form and add one logout functionality also.

Abh1shekSingh commented 2 years ago

@Abh1shekSingh after login also it is showing welcome username in the same login page. So add one more page for welcome or disable that login form after login.

My job was to add authentication only. and display the name.

@Abh1shekSingh because of this login form the person can login multiple times even they are already logged in. So disable login button or hide this login form and add one logout functionality also.

@Abh1shekSingh after login also it is showing welcome username in the same login page. So add one more page for welcome or disable that login form after login.

My job was to add authentication only. and display the name.

@Abh1shekSingh because of this login form the person can login multiple times even they are already logged in. So disable login button or hide this login form and add one logout functionality also.

Will add Sign Out Functionality in my other PR #810 and #809 . @DEEPIKA-SUK I will add A signout button on Welcome Page which will allow user to get sign out and redirect to login form back

Abh1shekSingh commented 2 years ago

@DEEPIKA-SUK Please review now, i have done the required changes

Abh1shekSingh commented 2 years ago

style_links.json update karo

Yeh, Already existed project hai aapka. Usme authentication add ki hai mene

DEEPIKA-SUK commented 2 years ago

@Abh1shekSingh after login also it is showing welcome username in the same login page. So add one more page for welcome or disable that login form after login.

My job was to add authentication only. and display the name.

@Abh1shekSingh because of this login form the person can login multiple times even they are already logged in. So disable login button or hide this login form and add one logout functionality also.

@Abh1shekSingh after login also it is showing welcome username in the same login page. So add one more page for welcome or disable that login form after login.

My job was to add authentication only. and display the name.

@Abh1shekSingh because of this login form the person can login multiple times even they are already logged in. So disable login button or hide this login form and add one logout functionality also.

Will add Sign Out Functionality in my other PR #810 and #809 . @DEEPIKA-SUK I will add A signout button on Welcome Page which will allow user to get sign out and redirect to login form back

Okay rest is good.

github-actions[bot] commented 2 years ago

Thank you @Abh1shekSingh for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)