search

arpittyagi102 / Humari-Dukan

Humari Dukan is a E-Commerce website using React with Redux and Bootstrap
https://humaridukan.netlify.app/
MIT License
19 stars 27 forks source link

Change <a> tag in Navbar component to Link #27

Closed Akash1965 closed 1 year ago

Akash1965 commented 1 year ago

Change <a> tag to Link in Navbar component since the Navbar component is wrapped with React router

arpittyagi102 commented 1 year ago

Hey @Akash1965, Yes you are right, thank you for pointing out

aasimtaif commented 1 year ago

Hi, I am new to open source can I work on this issue

arpittyagi102 commented 1 year ago

Sure @aasimtaif, I have assigned you the issue. you can work on it.

aasimtaif commented 1 year ago

thanks

The-Alan-Turing commented 1 year ago

Hi, I am new to open source can I work on this issue

Sorry, I just opened a PR on this. If you still intend to work on this, let me know. I would close this PR.

aasimtaif commented 1 year ago

You don't need the link tag in the navbar as it is not redirecting to any page if I change to p or h tag the navbar will work as it is

arpittyagi102 commented 1 year ago

Hello contributors, i think he is right, it does not need the change. I will close this issue. Also Have a look at my repository github.com/arpittyagirocks/LinkUp It is under development and has a lot of scope for contributions. I am planning to build it GREAT