arpittyagi102 / LinkUp

Link Up is a real time chatting application project, it utilizes, MERN, socket.io
https://getlinkup.vercel.app
MIT License
22 stars 30 forks source link

Add Validator in login and signup form #4

Closed arpittyagi102 closed 1 year ago

arpittyagi102 commented 1 year ago

Hello contributers, i want someone to add validator in login and sign up forms.

TechVisionWeb commented 1 year ago

Hey - I am happy to help. This is obviously my first issue to attempt to commit to open source.

arpittyagi102 commented 1 year ago

Hello @TechVisionWeb, Welcome to the world of open source contributions, I have assigned you the issue, Do not hesitate to ask anything, I will try my best to help.

TechVisionWeb commented 1 year ago

Hi @arpittyagirocks I am not sure about the database connection URL or JWT secret key. Is this neccesary for my contribution and if so, what information can you recommend as a source? I am looking at app.js.

arpittyagi102 commented 1 year ago

If you look at the "LoginPage.jsx" and "SignupPage.jsx" database is already connected for authentication. But it still sends response to database even if input fields are empty and also it allows to submit even if we enter any string in the email input field in Sign up page I hope i am clear.

TechVisionWeb commented 1 year ago

Hello - I am going to withdraw because I wasn't aware of the use of react and JSX. I should have probably looked through some of the source code on github first

elidakirigo commented 1 year ago

hello, I'd like to assist in the validation of this repository, I am aware of the use of react

arpittyagi102 commented 1 year ago

Hello @elidakirigo, I have assigned you the issue you can start working on it.

arpittyagi102 commented 1 year ago

Hey @elidakirigo, I am also trying to write docs for the project on the way, You can have a look at loginpage.md

elidakirigo commented 1 year ago

thanks @arpittyagirocks i will look at the docs before i start working on it.

arpittyagi102 commented 1 year ago

Hey @elidakirigo, As you can see i did the login signup communication with socket.io, But to follow Industry standards now i am planning to change it all with http requests in express and routes, Will you be able to do that?

elidakirigo commented 1 year ago

Hey @elidakirigo, As you can see i did the login signup communication with socket.io, But to follow Industry standards now i am planning to change it all with http requests in express and routes, Will you be able to do that?

hi, @arpittyagirocks when are you doing the changes, please? i will be able to work around it, yes

arpittyagi102 commented 1 year ago

I want you to it, set up app.routes for sign up and login, shouldn't be hard

elidakirigo commented 1 year ago

I want you to it, set up app.routes for sign up and login, shouldn't be hard

okay

elidakirigo commented 1 year ago

hi, @arpittyagi102 how do I work around this issue SimpleCrypto object MUST BE initialised with a SECRET KEY.

screenshot

Link-Up-error

arpittyagi102 commented 1 year ago

Either you can use a dummy value which would cause error in "Wrong Password" Or you may comment all the code using "bycrypt" and "cookies" I hope it helps

elidakirigo commented 1 year ago

okay, thankyou, let me try

Seckrel commented 1 year ago

env files issue and project setup issue solved in pr #21 hope it helps

elidakirigo commented 1 year ago

thanks @Seckrel