search

arporter / habakkuk

Fortran code analysis for performance prediction
11 stars 0 forks source link

Running habakkuk with no arguments causes crash! #23

Closed arporter closed 7 years ago

arporter commented 7 years ago

It should produce a usage message at the very least...

arporter commented 7 years ago

This also highlights that I have no tests for the top-level habakkuk script. I'll add some as part of this issue.

arporter commented 7 years ago

Created branch usage_message for this work. Added a failing test that runs habakkuk without arguments and checks for a usage message.

arporter commented 7 years ago

Accidentally tagged a couple of commits with number 21 instead of 23. Anyway, decided that it was actually better to leave runner() raising IOErrors. Now catch these in the top-level habakkuk script, print associated error message and exit. Checked whether I can get a coverage report for the habakkuk script and I can - just provide the top-level directory as the argument to --cov and it reports on everything below that.

arporter commented 7 years ago

Discovered that I'd been slack in the way I was setting the location of the habakkuk script in the cmd-line tests. Fixed that and travis now passes :-)

arporter commented 7 years ago

Pull request #32 has been merged. Closing Issue.