search

arporter / habakkuk

Fortran code analysis for performance prediction
11 stars 0 forks source link

Increase test coverage #3

Closed arporter closed 8 years ago

arporter commented 8 years ago

Testing is rudimentary at the moment. In this ticket I will improve the coverage of the test suite. This will then provide firmer foundations for future development.

arporter commented 8 years ago

Created test_coverage branch for this work. Coverage is currently 86% for dag_node, and 78% for both dag and make_dag.

arporter commented 8 years ago

Coverage of dag.py has increased from 78% to 87%. A lot of the missed code is debug output that I should probably remove.

arporter commented 8 years ago

Finally, removed all if DEBUG: code.Coverage is now 97% for dag.py. Missed lines are mainly related to FMAs and instruction latency. The former will be brought back in in #1.

I'll tackle dag_node.py next...

arporter commented 8 years ago

Coverage of dag_node.py is now 99%. The single missed line is related to FMAs and will be tackled in #1.

Coverage of parse2003.py is currently 80%. I'll tackle that next...

arporter commented 8 years ago

Coverage of parse2003.py is now 100%. Doing this revealed that our support for indirect array accesses is still rather hacky and won't work with loop unrolling. I'll create a new Issue for that topic.

Final file to tackle is make_dag.py. Its coverage is currently 80%.

arporter commented 8 years ago

Overall test coverage is now 98% with 21 lines of code missed. These are mostly related to FMA support which will come back in #1 once we can support a microarch that actually has FMA. We have 53 tests with 3 xfailing. All code has been checked for pep8 and pylint.

arporter commented 8 years ago

test_coverage merged to master and deleted.