search

arpruss / USBComposite_stm32f1

USB Composite library for STM32F1 (HID, Serial, MIDI and XBox360 controller)
Other
382 stars 76 forks source link

PitchBend is a channel command #83

Closed MicroBahner closed 3 years ago

MicroBahner commented 3 years ago

Hello, as far as I know, the pitch bend command is a channel command. But sendPitchChange() doesn't allow to define a channel, and handlePitchChange() doesn't return the channel information. In my opinion this an error ( which could be fixed easily ;) ). Regards Franz-Peter

arpruss commented 3 years ago

I don't know much about MIDI. Can you make a fix and test it?

MicroBahner commented 3 years ago

I have already made the appropriate changes for my application. I will test a little more and then make a suggestion. Franz-Peter

MicroBahner commented 3 years ago

I created a pull-request with the necessary changes to add the channel info to the read/write methods for pitch bend.

arpruss commented 3 years ago

Thank you!