arpruss / gcodeplot

Use a 3-axis machine as a pen plotter
Other
167 stars 60 forks source link

Sync with @balthisar repo (inkscape 1.0 compatibility) #24

Closed chepo92 closed 3 years ago

arpruss commented 3 years ago

Does it still work with earlier versions?

chepo92 commented 3 years ago

Will need to check, if not maybe merge it in a new branch

arpruss commented 3 years ago

Does this need to be done at all? I copied the old extension to a 1.0 extensions folder and they seemed to work fine.

chepo92 commented 3 years ago

Looking at the diff, I think the major difference is line 456 in gcodeplot (if pen != 1:), as python complains when using "is not"

arpruss commented 3 years ago

That was fixed in an earlier patch I think.

chepo92 commented 3 years ago

it seems so, then closing this PR