search

arpruss / raspberryjammod

Raspberry Jam Mod - a Mod Forge Minecraft mod implementing most of Raspberry Juice/Pi API
http://www.instructables.com/id/Python-coding-for-Minecraft/
Other
348 stars 95 forks source link

Unable to build 1.11 and 1.12 using build.sh #41

Open Marcinosoft opened 5 years ago

Marcinosoft commented 5 years ago

Hi,

I just trying to compile using build.sh under Cygwin/Windows. It seems that following configs are incorrect:

https://github.com/arpruss/raspberryjammod/blob/master/111/build.gradle https://github.com/arpruss/raspberryjammod/blob/master/112/build.gradle

Can you correct Forge version from 2151 to exact version in both files? Also please correct mappings values and dependecy from ForgeGradle:2.2-SNAPSHOT to ForgeGradle:2.3-SNAPSHOT in /112/build.gradle as long 2.2 does not support MC 1.12.

Another request: please remove "--offline" within line: "sh gradlew --offline build" in: https://github.com/arpruss/raspberryjammod/blob/master/112/fast.sh

Last one: Change build.sh in root to unix end of lines (currently it contains Windows EOL, which cause error running under Cygwin).

Regards, Marcinosoft

arpruss commented 5 years ago

I want the offline to stay, as it's too slow otherwise. As for the version numbers, can you send me the ones you think are correct. It builds fine for me on cygwin.

Marcinosoft commented 5 years ago

Well, I tried to figure out which Forge version you are using as long Forge plugin complains about "2151":

Build file '...\raspberryjammod\112\build.gradle' line: 28

For 1.11 I set it to: version = "1.11-13.19.1.2199" mappings = "snapshot_20161220" and it works but I don't know it's really correct version.

For 1.12 I tried: version = "1.12-14.21.0.2320" mappings = "snapshot_20161220" and version = "1.12-14.21.1.2443" mappings = "snapshot_20170624"

both generates errors. Which Forge version is correct ?

Marcinosoft commented 5 years ago

Here is my 1.12 build sample error:

################################################# ForgeGradle 2.3-SNAPSHOT-7764e3e
https://github.com/MinecraftForge/ForgeGradle
################################################# Powered by MCP
http://modcoderpack.com
by: Searge, ProfMobius, R4wk, ZeuX
Fesh0r, IngisKahn, bspkrs, LexManos
################################################# :deobfCompileDummyTask :getVersionJson :extractUserdev Download https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.12-14.21.1.2428/forge-1.12-14.21.1.2428.pom Download https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.12-14.21.1.2428/forge-1.12-14.21.1.2428-userdev.jar :downloadClient SKIPPED :downloadServer SKIPPED :splitServerJar SKIPPED :mergeJars SKIPPED :applyBinaryPatches :deobfProvidedDummyTask :extractDependencyATs SKIPPED :extractMcpData SKIPPED :extractMcpMappings :genSrgs SKIPPED :deobfMcMCP Applying SpecialSource... Applying Exceptor... :sourceApiJava UP-TO-DATE :compileApiJava UP-TO-DATE :processApiResources UP-TO-DATE :apiClasses UP-TO-DATE :sourceMainJava UP-TO-DATE :compileJava...\raspberryjammod\112\build\sources\main\java\mobi\omegacentauri\raspberryjammod\GuiFactory.java:26: error: cannot find symbol public RuntimeOptionGuiHandler getHandlerFor( ^ symbol: class RuntimeOptionGuiHandler location: class GuiFactory ...\raspberryjammod\112\build\sources\main\java\mobi\omegacentauri\raspberryjammod\SetBlockNBT.java:12: error: cannot find symbol import net.minecraftforge.fml.common.registry.FMLControlledNamespacedRegistry; ^ symbol: class FMLControlledNamespacedRegistry location: package net.minecraftforge.fml.common.registry ...\raspberryjammod\112\build\sources\main\java\mobi\omegacentauri\raspberryjammod\SetBlocksNBT.java:9: error: cannot find symbol import net.minecraftforge.fml.common.registry.FMLControlledNamespacedRegistry; ^ symbol: class FMLControlledNamespacedRegistry location: package net.minecraftforge.fml.common.registry 3 errors FAILED

FAILURE: Build failed with an exception.

BUILD FAILED

arpruss commented 5 years ago

How do I check the Forge version? It's been a very long time since I set up the build system and I can't remember how I did it.

Marcinosoft commented 5 years ago

So is there really "2151" within your .\112\gradle.properties and ForgeGradle is able to build it ? Also your dependecy is really 2.2 ? dependencies { classpath 'net.minecraftforge.gradle:ForgeGradle:2.2-SNAPSHOT' }

2.2 says: "ForgeGradle 2.2-SNAPSHOT does not support Minecraft 1.12. MIN: 1.9.4, MAX: 1.11.2"

Marcinosoft commented 5 years ago

Another strange thing is that within your jar files for 1.11 and 1.12 within mcmod.info there is "mcversion": "1.10.2" It looks like your environment build almost the same content for 1.10, 1.11 and 1.12.

My jar for 1.11 have proper version within mcmod.info - "mcversion": "1.11" Strange...

Marcinosoft commented 5 years ago

It seems that 1.11 and 1.12 build base on MC 1.10.2.

To build it successfully, within both files: https://github.com/arpruss/raspberryjammod/blob/master/111/build.gradle https://github.com/arpruss/raspberryjammod/blob/master/112/build.gradle you should replace line: version = "2151" with: version = "1.10.2-12.18.2.2147"

Then build.sh works fine. It warns about mappings taken from 1.11 and 1.12 but jar files are created. Both 1.11 and 1.12 contains "mcversion": "1.10.2" within mcmod.info, like in your mods.zip archive.

Marcinosoft commented 5 years ago

I made few updates to build scripts/config files as pull request: https://github.com/arpruss/raspberryjammod/pull/42