search

arq5x / scurgen

A tool for detecting patterns in genomic data with space filling curves
9 stars 4 forks source link

m_dim or matrix_dim? #19

Closed daler closed 11 years ago

daler commented 11 years ago

A minor naming convention issue: HilbertMatrix has the matrix_dim kwarg, which upon initialization is passed to HilbertNormalized and HilbertBase. These base classes set the m_dim (rather than matrix_dim) attribute. I keep mixing them up. I think it would help to keep just one name and make it consistent across all classes . . . which name do you prefer?

arq5x commented 11 years ago

Good catch. I prefer matrix_dim as it is more explicit.