search

arqaamio / LogframeLab-server

Backend Server for Logframe Labs.
https://logframelab.ai
Other
1 stars 3 forks source link

Feature/add sort num times #13

Closed git-ari closed 4 years ago

git-ari commented 4 years ago

This branch was created on top of the add_columns one. Here I deleted the new sql file and put everything together, since even if I had put it in the new sql I would be deleting both tables.

I have to add tests to make sure everything is working, but I wanted to create this PR early so the team can take a look.

I removed the creation of temporary files, since it seemed to me it wasn't necessary, if you don't agree please tell me.

I would also like to know if I can delete the id from IndicatorResponse

alik90 commented 4 years ago

@git-ari this id from IndicatorResponse is used in the frontend

alik90 commented 4 years ago

@git-ari the temporary files are needed in case of uploading a very big documents