[#4wmyet] - Feature/additional filter columns

arqaamio / LogframeLab-server

Backend Server for Logframe Labs.

https://logframelab.ai

Other

1 stars 3 forks source link

[#4wmyet] - Feature/additional filter columns #16

Closed dotun closed 4 years ago

dotun commented 4 years ago

[#4wmyet]

Created a FilterDto type to hold filter options including: theme, source, sdg, dac and level.
Updated dependent files including IndicatorController, IndicatorService, IndicatorRepository and IndicatorRepositoryTest.
Updated some tests in IndicatorRepositoryTest, but need input from @git-ari to fix a couple.
Updated integration tests require creating integration_tests database on local machine with username and password specified in application-integration.properties file.

alik90 commented 4 years ago

@dotun i have done some tests, the application start failed and we have issue with the new flyway version and there is errors when runing the tests, can you please fix these issues and add the needed files (application-integration.properties) and others configurations if required, and please update the README.MD is there is any changes in the config and how to run the app and tests.

alik90 commented 4 years ago

Other issues: leaving the filters empty form frontend this error appears: org.springframework.web.multipart.support.MissingServletRequestPartException: Required request part 'filter' is not present at org.springframework.web.servlet.mvc.method.annotation.RequestPartMethodArgumentResolver.resolveArgument(RequestPartMethodArgumentResolver.java:161) ~[spring-webmvc-5.2.5.RELEASE.jar:5.2.5.RELEASE]

alik90 commented 4 years ago

@dotun i have merged the last PR's, please fetch the last version of develop branch and do the corrections

dotun commented 4 years ago

@dotun i have done some tests, the application start failed and we have issue with the new flyway version and there is errors when runing the tests, can you please fix these issues and add the needed files (application-integration.properties) and others configurations if required, and please update the README.MD is there is any changes in the config and how to run the app and tests.

I have fixed issues I was able to identify. Also, I have updated the README.MD to include instructions for integration tests.

dotun commented 4 years ago

Other issues: leaving the filters empty form frontend this error appears: org.springframework.web.multipart.support.MissingServletRequestPartException: Required request part 'filter' is not present at org.springframework.web.servlet.mvc.method.annotation.RequestPartMethodArgumentResolver.resolveArgument(RequestPartMethodArgumentResolver.java:161) ~[spring-webmvc-5.2.5.RELEASE.jar:5.2.5.RELEASE]

Fixed this with a default empty filter dto.

dotun commented 4 years ago

@dotun i have merged the last PR's, please fetch the last version of develop branch and do the corrections

Done as requested.