search

arqex / react-datetime

A lightweight but complete datetime picker react component.
2k stars 868 forks source link

Inaccurate years viewMode header #635

Open Pjohnsonator opened 5 years ago

Pjohnsonator commented 5 years ago

I'm Submitting a

[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

Open the datetime component to the years view

Screen Shot 2019-05-17 at 1 12 46 PM ^ From the codepen example

Expected Results

The .rdtSwitch header reflects the year range of the .rdtYear table cells below

Actual Results

The .rdtSwitch header reflects the year range of the decade, but the year range is [decade-1, decade+1]. e.g. 2010-2019 header with year options 2009-2020

Other Information

One solution could be changing YearsView.js ln 14 year + '-' + ( year + 9 ) to year-1 + '-' + ( year + 10 )

jandominik commented 5 years ago

Same issue on react-datetime version 2.16.3.

arqex commented 4 years ago

Keeps happening!

Sabarish-Vasudevan commented 3 years ago

Keeps happening!

I have created a PR to fix this issue. Please check and merge if the changes are fine. PR