search

arqex / react-datetime

A lightweight but complete datetime picker react component.
2k stars 870 forks source link

Fixes findDOMNode deprecated warning in Strict Mode #725

Closed kkalve closed 4 years ago

kkalve commented 4 years ago

Description

Changed react-onclickoutside package usage - providing ref for ClickOutBase component

Motivation and Context

Due to updates in react around strict mode, findDOMNode raises warning. Error raises in react-onclickoutside package where refs should be used instead findDOMNode. Package has been updated to 6.9.0 where this issue has been solved (https://github.com/Pomax/react-onclickoutside/issues/315), but react-datetime package needs some changed regarding this. Fixes issue: #626

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly
arqex commented 4 years ago

Thanks for this PR that fixes a very annoying issue! closes https://github.com/arqex/react-datetime/issues/626