arqex / react-datetime

A lightweight but complete datetime picker react component.
2k stars 870 forks source link

Fix tests and replace travis with github actions #761

Closed anajavi closed 2 years ago

anajavi commented 3 years ago

Upgrade testing tools to latest versions

Description

Motivation and Context

To make testing easier.

fixes #780

Github actions sample run: https://github.com/anajavi/react-datetime/runs/4204940938?check_suite_focus=true

Checklist

[X] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[X] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly
anajavi commented 3 years ago

Dropped node 10 too as it is obsolete in one week.

anajavi commented 3 years ago

@arqex this fixes the CI, so that other PR's can be unblocked. Would you consider merging this?

johnhunter commented 3 years ago

Any news on this? The maintainers listed from npm info react-datetime are @arqex @simeg @layneanderson - anyone able to merge this? I also have a couple of suggestions for managing dependencies that might be worth considering https://github.com/arqex/react-datetime/issues/780

johnhunter commented 2 years ago

Nice @anajavi 👍 Would be great to get this merged, otherwise I think I'll need to maintain a fork and recreate some of these PRs on there.

johnhunter commented 2 years ago

So this wasn't merged - what a shame 😞