search

arqex / react-datetime

A lightweight but complete datetime picker react component.
2k stars 870 forks source link

Allow react 17 as peerDependency #764

Closed anajavi closed 3 years ago

anajavi commented 3 years ago

Adds react 17 as peerDependency to prevent warnings.

Description

Allows react 17 as peerDependency fixes #792 fixes #774

Motivation and Context

react-datetime works with react 17.

Testing against react 17 is blocked by enzyme-adapter-17, which still in development: https://github.com/enzymejs/enzyme/pull/2430

Checklist

[X] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[X] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly
zackdotcomputer commented 3 years ago

Resolves #774

tamal-appsbee commented 3 years ago

Please merge it.

dmathijs commented 3 years ago

Why does this remain open?

zackdotcomputer commented 3 years ago

@arqex hasn't been very active on Github since last fall and IDK if anyone else has merge rights on the repo.

arqex commented 3 years ago

Thanks @anajavi for sending the change and @layneanderson for merging it! I've just published the v3.1.0 with react 17 as peer dependency.