search

arqex / react-datetime

A lightweight but complete datetime picker react component.
1.99k stars 873 forks source link

Refactor moment out #816

Open reharik opened 2 years ago

reharik commented 2 years ago

Hi, if I refactor this project to use luxon rather than moment, would y'all be ready to merge it pretty quickly? It's a decent chunk of work and I don't want to mess with it if it's not going to be merged. I could either use luxon internally and then expose native date types or expose luxon datetime to the consumers. Or for that matter if you have other thoughts I can do it however, just need to get off of moment. Thanks, Raif

peetjvv commented 2 years ago

I'm also finding the fact that this project uses moment as a bit of a barrier when migrating from moment to luxon. Need to either use a different date picker or update this project to use luxon instead of moment.

SeanCassiere commented 1 year ago

Maybe consider using date-io, to allow for any date library to be usable. As such, people could use adapters like luxon, date-fns, dayjs, or even a custom one.

Date-io is also what's being used by MUI's Datepickers.