search

arqex / react-datetime

A lightweight but complete datetime picker react component.
1.99k stars 872 forks source link

Allow usage with react 18 #838

Closed alexander-schranz closed 1 year ago

alexander-schranz commented 1 year ago

Description

Allow usage with react 18.

Motivation and Context

Avoid: "react-datetime@3.1.1 requires a peer of react@^16.5.0 || ^17.0.0 but none is installed"

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[-] I have added tests covering my changes
[x] All new and existing tests pass
[-] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly
jedfong commented 1 year ago

Any estimate on when this change will be merged/published?

hasanbisha commented 1 year ago

it any help needed with this pr? i can give a hand

yadomi commented 1 year ago

Hi @arqex, could this be merged ? Also, this one https://github.com/arqex/react-datetime/pull/789 should probably be closed in the mean time

arqex commented 1 year ago

Sorry for taking so long to merge 🙏 I've just published v3.2.0 that includes the support for react 18