arquicanedo / barbecueboss

Barbecue ConnectIQ App for Garmin Devices
Apache License 2.0
5 stars 0 forks source link

[Tenergy] Custom timer should allow hh:mm:ss format #96

Closed arquicanedo closed 4 years ago

arquicanedo commented 4 years ago

Smoking sessions need hours.

nilsbenson commented 4 years ago

agreed. we need to modify the duration picker to allow for hours, and configurable so we can disable that on the flip/total timers.

I think we drop the seconds on the display in SmokeView - it's not terribly useful and you can see the lag when it updates and it's also getting temperature data from the probe at the same time.

arquicanedo commented 4 years ago

I pushed a change to allow for MM:SS and HH:MM. The only difference is the text at the top. The caller should interpret the meaning of the time array (time[0]*60 + time[2]).

Since the smokerView is updating every minute, would it make sense to create another timer? I think old devices support up to 3 timers. I read that somewhere in the forums.

nilsbenson commented 4 years ago

looks good, works well for the smoke-related times

arquicanedo commented 4 years ago

Closing