search

arquillian / arquillian-algeron

12 stars 8 forks source link

Investigate how to add sun.net and com.sun.net packages #77

Open lordofthejars opened 7 years ago

lordofthejars commented 7 years ago

Currently we are adding one by one classes required by Pact from package sun.net and com.sun.net, cannot use ShirnkWrap packages method because rt.jar was packaged without the directory entries (Full description here https://github.com/arquillian/arquillian-algeron/pull/76) so we need to figure out if there is a better way of doing this instead of adding one by one.

Class that needs to be improved is https://github.com/arquillian/arquillian-algeron/blob/master/pact/consumer/core/src/main/java/org/arquillian/algeron/pact/consumer/core/client/PactConsumerArchiveAppender.java

bartoszmajsak commented 7 years ago

The description is wrong. Please read my comments in the closed PR.

lordofthejars commented 7 years ago

Fixed