search

arquillian / arquillian-container-tomcat

Arquillian Containers for Tomcat
https://arquillian.org
25 stars 36 forks source link

Change Embedded Tomcat 10 to support version 10.1 for EE 10 #118

Closed manovotn closed 2 years ago

manovotn commented 2 years ago

Fixes #117

This is what I discovered as needed parts so far.

Though I am still seeing bunch of errors where I am not sure if they are caused by wrong setup in this adapter or on Weld side. I am trying to make sense of it before we cut any release here.

manovotn commented 2 years ago

Ok, this PR seems to be complete. With these changes I can execute Weld tests against Tomcat 10.1. @starksm64 this should be ready for merge and release.

Note that the CI is "stuck" because it still references Travis, we'd need to switch to GH actions and since this projects hosts very old adapters, a single JDK version might not be able to build/test them all. If we want to fix that, it might make sense to create a branch out of current state and then clean up master, only leaving latest versions of adapters.

starksm64 commented 2 years ago

Ok, we had the same problem with the Jetty container adaptor. Let's create a branch for the javax.servlet based Tomcat versions and remove those from the main branch.