arquillian / arquillian-core

Arquillian provides a component model for integration tests, which includes dependency injection and container life cycle management. Instead of managing a runtime in your test, Arquillian brings your test to the runtime.
http://arquillian.org
Apache License 2.0
366 stars 196 forks source link

[580] Create some integration tests. Create profiles for WildFly to r… #581

Open jamezp opened 2 days ago

jamezp commented 2 days ago

…un the tests.

Short description of what this resolves:

Introduce some integration tests.

Changes proposed in this pull request:

Fixes #580

lprimak commented 2 days ago

See https://github.com/flowlogix/base-pom the way I did this for Payara so that profiles are not repeated for every project. Also see https://github.com/flowlogix/depchain/tree/main/integration-test for how I automatically integrate testcontainers, and remote / local / k8s payara in a common, easy-to-use way

starksm64 commented 1 day ago

@jamezp What about not having this inherrit the arquillian-parent pom and only use the bom? The reason is that it can be used to test any version of arquillian-core. For example, I have a local 1.9.0.Final-SNAPSHOT build and I want to run these test against it, but I have to go through all of the poms and update the version. If it was just importing the bom and using a property, it could be retargeted using a command line override.

starksm64 commented 1 day ago

I guess I can already override the version on the command line.

jamezp commented 1 day ago

Yeah, you should be able to override it. It definitely doesn't need to have the parent POM for sure. I'll make sure to set it up to allow all dependencies to be overridden so we can test in CI too.