search

arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!
http://arquillian.org/arquillian-cube/
120 stars 98 forks source link

Close all cubes, even on error #1059

Closed AndyGee closed 6 years ago

AndyGee commented 6 years ago

Short description of what this resolves:

A call to stop is not guaranteed to complete:

Exception in thread "Thread-4" org.arquillian.cube.spi.CubeControlException: Could not stop vnc at org.arquillian.cube.spi.CubeControlException.failedStop(CubeControlException.java:23) at org.arquillian.cube.docker.impl.model.DockerCube.stop(DockerCube.java:169) at org.arquillian.cube.impl.client.ForceStopDockerContainersShutdownHook.lambda$attachShutDownHookForceStopDockerContainers$0(ForceStopDockerContainersShutdownHook.java:17) at java.lang.Thread.run(Thread.java:748)

This prevents the call to other cubes from completing.

Changes proposed in this pull request:

Catch and log errors, but continue to process.

Fixes #

AndyGee commented 6 years ago

Not sure how to squash those commits? The last one is relevant, and only changes one file.

bartoszmajsak commented 6 years ago

Not sure how to squash those commits? The last one is relevant, and only changes one file.

We do squash and merge from GH, so don't worry about that @AndyGee