arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!
http://arquillian.org/arquillian-cube/
120 stars 98 forks source link

Enable setting IstioResource on test methods in addition to test class #1083

Closed geoand closed 6 years ago

geoand commented 6 years ago

Fixes: #1082

geoand commented 6 years ago

@lordofthejars You are most welcome!

I updated the logging messages with your suggestion

geoand commented 6 years ago

@lordofthejars Thanks for the clarification :P. I was already on the fence and your suggestion made perfect sense :)

lordofthejars commented 6 years ago

@geoand Merged, thanks for the improvement, do you need a release soon or we can wait until more features are added?

geoand commented 6 years ago

No problem :)

No, we are not in any hurry for a new release. It's just an improvement I spotted when working on some tests. So I believe it's best to wait until more features pile up to do a release