In a CI environment the DockerUri and DockerServer may not be interchangeable if the CI is not the actual DinD server, rather it has started and mapped a DinD runner.
If image XYZ is exposing port 4321 and dockerInsideDockerResolution is true (default) and the container is started by the DinD then dockerServerIp:4321 will be accessible.
However, if the DinD host is a runner then dockerInsideDockerResolution is false (ie. dockerServerIp is not the DinD), and the serverUri host should be used (which will be set to something like http://myDindAlias:2375), somyDindAlias:4321 will be accessible.
I'll provide a better description with diagrams in a later PR. It's complicated at best ;-)
Changes proposed in this pull request:
Browser image, name and port override and enhance for DinD.
Fixed a few tests for windows and updated for DinD.
Providing more useful logging.
Set the recommended minimum SHM size for selenium container.
In a CI environment the DockerUri and DockerServer may not be interchangeable if the CI is not the actual DinD server, rather it has started and mapped a DinD runner.
If image XYZ is exposing port 4321 and
dockerInsideDockerResolution
is true (default) and the container is started by the DinD thendockerServerIp:4321
will be accessible.However, if the DinD host is a runner then
dockerInsideDockerResolution
is false (ie. dockerServerIp is not the DinD), and theserverUri
host should be used (which will be set to something like http://myDindAlias:2375), somyDindAlias:4321
will be accessible.I'll provide a better description with diagrams in a later PR. It's complicated at best ;-)
Changes proposed in this pull request:
Fixes #1107