arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!
http://arquillian.org/arquillian-cube/
120 stars 98 forks source link

Allow browser image, name and port override and enhance for DinD #1128

Open AndyGee opened 5 years ago

AndyGee commented 5 years ago

In a CI environment the DockerUri and DockerServer may not be interchangeable if the CI is not the actual DinD server, rather it has started and mapped a DinD runner.

If image XYZ is exposing port 4321 and dockerInsideDockerResolution is true (default) and the container is started by the DinD then dockerServerIp:4321 will be accessible.

However, if the DinD host is a runner then dockerInsideDockerResolution is false (ie. dockerServerIp is not the DinD), and the serverUri host should be used (which will be set to something like http://myDindAlias:2375), somyDindAlias:4321 will be accessible.

I'll provide a better description with diagrams in a later PR. It's complicated at best ;-)

Changes proposed in this pull request:

Fixes #1107

bartoszmajsak commented 4 years ago

@AndyGee @lordofthejars are we moving forward with this PR?