search

arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!
http://arquillian.org/arquillian-cube/
120 stars 98 forks source link

Upgrade many dependencies #1242

Open papegaaij opened 2 years ago

papegaaij commented 2 years ago

This pull requests upgrades many dependencies. No functional changes were made.

bartoszmajsak commented 2 years ago

Thanks for this work @papegaaij. Any clues why tests are failing? https://app.circleci.com/pipelines/github/arquillian/arquillian-cube/37/workflows/ae2941fb-64d3-4d65-b050-465f39cffcad/jobs/167?invite=true#step-104-1315

papegaaij commented 2 years ago

@bartoszmajsak, no not really. It seems to be related to the CI environment. The tests pass when I run them locally. I do have an issue building arquillian-cube-openshift on JDK 11 though, because it uses sun.net.spi.nameservice.NameService: 

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project arquillian-cube-openshift: Compilation failure: Compilation failure: 
[ERROR] /home/papegaaij/tmp/arquillian-cube/openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/dns/ArqCubeNameService.java:[4,31] package sun.net.spi.nameservice does not exist
[ERROR] /home/papegaaij/tmp/arquillian-cube/openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/dns/ArqCubeNameService.java:[18,44] cannot find symbol
[ERROR]   symbol: class NameService
[ERROR] /home/papegaaij/tmp/arquillian-cube/openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/dns/ArqCubeNameServiceDescriptor.java:[4,31] package sun.net.spi.nameservice does not exist
[ERROR] /home/papegaaij/tmp/arquillian-cube/openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/dns/ArqCubeNameServiceDescriptor.java:[5,31] package sun.net.spi.nameservice does not exist
[ERROR] /home/papegaaij/tmp/arquillian-cube/openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/dns/ArqCubeNameServiceDescriptor.java:[14,54] cannot find symbol
[ERROR]   symbol: class NameServiceDescriptor
[ERROR] /home/papegaaij/tmp/arquillian-cube/openshift/openshift/src/main/java/org/arquillian/cube/openshift/impl/dns/ArqCubeNameServiceDescriptor.java:[17,12] cannot find symbol
[ERROR]   symbol:   class NameService
[ERROR]   location: class org.arquillian.cube.openshift.impl.dns.ArqCubeNameServiceDescriptor
[ERROR] -> [Help 1]
bartoszmajsak commented 2 years ago

I've been trying to build it locally but it fails for different reasons on different JVM versions :) Summoning @lordofthejars

papegaaij commented 2 years ago

I don't know if it's an option to upgrade to a more recent JDK, but locally I've managed to build everything with JDK8.