[TASK]:Build with JDK11.

arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!

http://arquillian.org/arquillian-cube/

117 stars 98 forks source link

[TASK]:Build with JDK11. #1270

Open jimma opened 7 months ago

jimma commented 7 months ago

This needs upgrade the jboss-parent to the latest one and bump other dependencies version.

rsearls commented 7 months ago

Please assign this to me. I am starting work on it now.

jimma commented 7 months ago

@rsearls We still didn't find the people who can assign issue. Please directly start to work on this issue.

rsearls commented 7 months ago

Thanks. Started it yesterday after posting my comment in the issue.

On Tue, Nov 28, 2023 at 1:40 AM jimma @.***> wrote:

@rsearls https://github.com/rsearls We still didn't find the people who can assign issue. Please directly start to work on this issue.

— Reply to this email directly, view it on GitHub https://github.com/arquillian/arquillian-cube/issues/1270#issuecomment-1829206183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD3X45WOHGSDNH25KNABO3YGWBORAVCNFSM6AAAAAA7V65IHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGIYDMMJYGM . You are receiving this because you were mentioned.Message ID: @.***>

gaol commented 7 months ago

@rsearls With some discussions on https://github.com/arquillian/arquillian-cube/pull/1276, I think it will be great to address the following issues too with this issue:

Enable JDK 11 in the github action workflow (if it gets merged before this one :) )
A sun.net.spi.nameservice.NameService implementation in openshift/openshift module should not work anymore with upgrading to JDK 11, as the NameService got dropped from JDK9+, we need to decide how to do with it.

Thanks :)

rsearls commented 7 months ago

@gaol I recommend the changes for those 2 issues be submitted under separate PRs after code for this PR had been merged, so if anything needs to be backed out, it can be easily done.

In addressing this JDK-11 compile issue nearly all dependencies have had to be upgraded and many class files required corresponding changes. I believe the better strategy is to get clean compiling code and use that as the base to refine the project moving forward.

gaol commented 7 months ago

@rsearls that makes sense to me, thanks. :)