search

arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!
http://arquillian.org/arquillian-cube/
117 stars 98 forks source link

Create DockerClient method for starting Container Objects #298

Open lordofthejars opened 8 years ago

lordofthejars commented 8 years ago

Create DockerClient method for starting Container Objects, objects that are annotated with @Cube, programmatically. So you can do something like:

dockerClient.create(SSHContainer.class)

It might be dockerClient or CubeController but provide some way to do it.

lordofthejars commented 8 years ago

This issue might need first this fix if we want to support in-container too. https://github.com/arquillian/arquillian-cube/issues/231

aslakknutsen commented 8 years ago

Start with client side support. Then if we see a need for it, create an in container issue.

lordofthejars commented 8 years ago

in CubeController or in DockerClient? I think best is CubeController.

aslakknutsen commented 8 years ago

The ContainerObject impl is in Core right? If in Core then CubeController.

lordofthejars commented 8 years ago

No it is in Docker side.

El dj., 25 febr. 2016 a les 12:16, Aslak Knutsen (notifications@github.com) va escriure:

The ContainerObject impl is in Core right? If in Core then CubeController.

— Reply to this email directly or view it on GitHub https://github.com/arquillian/arquillian-cube/issues/298#issuecomment-188735459 .

aslakknutsen commented 8 years ago

We should probably extract some of the Core features around ContainerObjects and move them to Core. That way we can just as well have OpenShift based ContainerObjects as Docker.

But we can expose this on DockerClient until that is done.

lordofthejars commented 8 years ago

agreed

El dj., 25 febr. 2016 a les 12:28, Aslak Knutsen (notifications@github.com) va escriure:

We should probably extract some of the Core features around ContainerObjects and move them to Core. That way we can just as well have OpenShift based ContainerObjects as Docker.

But we can expose this on DockerClient until that is done.

— Reply to this email directly or view it on GitHub https://github.com/arquillian/arquillian-cube/issues/298#issuecomment-188740877 .

lordofthejars commented 8 years ago

Design: https://gist.github.com/aslakknutsen/2452f126eb428bca7a95

https://github.com/arquillian/arquillian-cube/blob/master/docker/docker/src/main/java/org/arquillian/cube/docker/impl/client/CubeDockerExtension.java#L27