search

arquillian / arquillian-cube

Control (docker, kubernetes, openshift) containers in your tests with ease!
http://arquillian.org/arquillian-cube/
117 stars 98 forks source link

Align the way kubernetes and openshift client is configured #445

Open iocanel opened 7 years ago

iocanel commented 7 years ago

So right now we have two modules that are configured with a completely different way.

They use different ways to pass configuration to the plugin and also configuration property names. For example:

arquillian-cube-kubernetes is using kubernetes.master while arquillian-cube-openshift is using originServer.

I think that we should have a common name to define common things across these modules. Maybe the arquillian guys can provide some details about possible naming conventions being used.

Next step is to provide a common set of properties (where applicable) that will work in parallel with the existing ones (which we will mark as deprecated).

Now regarding the possible ways of defining configuration the kubernetes module is using the system properties > environment variable > arquillian.xml which I believe that should also be used in the openshift side.

EDIT: Fixed typo.

lordofthejars commented 7 years ago

I think that here

arquillian-cube-kubernetes is using kubernetes.master while arquillian-cube-kubernetes is using originServer.

you mean arquillian-cube-openshift. In theory in the future, after kubernetes part is fully integrated with cube model, openshift part should contain only things specific to openshift.