should_report_network_topology_of_docker_containers fails

[iocanel]

https://github.com/arquillian/arquillian-cube/blob/f8b0ac239314976bb5c84d88ff8dbc8888a823c2/docker/recorder/src/test/java/org/arquillian/cube/docker/impl/client/reporter/TakeDockerEnvironmentTest.java#L284

It seems that no behavior is defined for this test case.

[lordofthejars]

What you mean by no behaviour, there is some assertions that asserts that the information is correctly created.

[iocanel]

I mean that the mock doesn't seem to define any behavior for the inspect method, which is indirectly called (resulting in an NPE).

[lordofthejars]

No, we are using the object just for capturing the result inside. https://github.com/arquillian/arquillian-cube/blob/f8b0ac239314976bb5c84d88ff8dbc8888a823c2/docker/recorder/src/test/java/org/arquillian/cube/docker/impl/client/reporter/TakeDockerEnvironmentTest.java#L293

[iocanel]

Does the test work for you?

[dipak-pawar]

@iocanel test is not working. Let me check what's wrong with it.

[dipak-pawar]

Submitted PR for above issue. Thanks @iocanel

[iocanel]

You may have to use something like the @RequiresDocker annotation so that the test will not fail on environments where docker is not available (e.g. circleci).

[dipak-pawar]

@iocanel there is bug in test code. No need to mention @RequiresDocker annotation for this tests as we are providing networkMode from dockerContainers properties, and you will never reach this scenario.

[lordofthejars]

@iocanel fixed and merged :)