[ARQ-1104] - Spring deployer should include all spring artifacts.

arquillian / arquillian-extension-spring

Arquillian Spring Containers and Enrichers

27 stars 26 forks source link

[ARQ-1104] - Spring deployer should include all spring artifacts. #16

Closed jmnarloch closed 11 years ago

jmnarloch commented 12 years ago

For review and pull upstream.

jmnarloch commented 11 years ago

@aslakknutsen Got some stuff to merge, when you find time.

jmnarloch commented 11 years ago

@aslakknutsen Hello? :)

aslakknutsen commented 11 years ago

Your packaging up all of spring every time here right?

It seems to double the runtime of the int test suites. And i'm not sure a user would always want everything. Maybe add them based on artifact/packages found on application classpath as default?

jmnarloch commented 11 years ago

@mbogoevici What do you think? Should we include all artifacts? Or do some classpath scanning?

mbogoevici commented 11 years ago

I think we should allow three different configurable modes:

POM-based (dependencies available in the BOM should we packaged) or CP-based - default
no-deps (no Spring dependencies included;
all-deps (all Spring deps included).

Of the three, the last one is the hardest to build a case for (as the dependency set is by design different from the one used in the actual application), but it can have its uses.

jmnarloch commented 11 years ago

Change has been merged and pushed upstream: https://github.com/arquillian/arquillian-extension-spring/commit/c4b148de5972f5e5faa7e2cab3841a4108d75724.