search

arquillian / arquillian-extension-spring

Arquillian Spring Containers and Enrichers
27 stars 26 forks source link

[ARQ-1277] - For consistency with other Warp extensions the captured run... #22

Closed jmnarloch closed 11 years ago

jmnarloch commented 11 years ago

...time state can be injected through @ArquillianResource.

To push upstream.

Some advice how to merge this changes: I had to update the implementation to Warp Alpha 2, becouse without it the test hang up unexpectedly, so this PR will conflict with [ARQ-1269]. You can just apply the previouse patch and from this one choice only the providers, SpringWarpRemoteExtension and the tests from warp-spring-ftest, other stuff is insignificant.

I marked SpringMvcResource as deprecated. Since we are still before releasing 1.0.0.Final, when actually I would be able to remove this annotation entirely? What is the approach here? :)

@aslakknutsen Will you find some time next week to push all the pull requests? :)

aslakknutsen commented 11 years ago

We're in Beta which means Locked API. No breaking changes. Deprecating something is not a problem as long as it still works.. It can be removed in e.g. 1.1

aslakknutsen commented 11 years ago

@jmnarloch yes, I owe you a few pull request pushed here.. :)

jmnarloch commented 11 years ago

Pushed upstream https://github.com/arquillian/arquillian-extension-spring/commit/8e4be474ed03a82c98268ab9e8c3cec834345d66