search

arquillian / arquillian-extension-spring

Arquillian Spring Containers and Enrichers
27 stars 26 forks source link

ARQ-945, Separated the integration module from deployer. #4

Closed jmnarloch closed 12 years ago

jmnarloch commented 12 years ago

@aslakknutsen Is this what you had in mind?

aslakknutsen commented 12 years ago

Excellent.. pushed up stream: https://github.com/arquillian/arquillian-extension-spring/commit/74ad8ea975df3ee29cf516ef80072a84303055eb

(reactivated the default container config for int test 2.5)

aslakknutsen commented 12 years ago

One little comment, I would look into reusing the test framework exposed by Arquillian Core when testing the extension. It can bind objects to scopes, fire events etc.. You don't have to mock everything and do manual injection of your Observers.

Example: https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-impl/src/test/java/org/jboss/arquillian/drone/impl/EnricherTestCase.java

jmnarloch commented 12 years ago

Thanks,

I will open a pull request for the embedded container during this week.