search

arquillian / arquillian-extension-spring

Arquillian Spring Containers and Enrichers
27 stars 26 forks source link

ARQ-219. Spring Embedded Container. #6

Closed jmnarloch closed 12 years ago

jmnarloch commented 12 years ago

Spring Embedded Container allows to tests JAR and WAR archives. Currently it may be used for testing buissnes objects. It does not anyhow mock the servlet container so it's not capable of testing web applications.

The embedded container uses the ApplicationProducer from inetgration module in order to instatiate the Spring's application context used during tests.

jmnarloch commented 12 years ago

Whoops, going to push a update ASAP.

jmnarloch commented 12 years ago

The test is in place, I would like to have all 4 pull request merged, if that wouldn't be a problem :)

On Saturday I can prepare the release note and upgrade the showcase to Alpha 2.

aslakknutsen commented 12 years ago

I can merge the ARQ-219 and the two Alpha2 fixe pull request. But keep ARQ-1019 as a separate since it's really not related.

aslakknutsen commented 12 years ago

or actually..

Merge ARQ-219 and PreAlpha2 since they basically work on the same structure.

But keep WarpTests and ARQ-1019 separate as they really deal with other unrelated parts of the code.

jmnarloch commented 12 years ago

Ok, fine by me.

aslakknutsen commented 12 years ago

or maybe you didn't mean merged in that sense, but rather pushed upstream ? :)

jmnarloch commented 12 years ago

That's what I had in mind :)

aslakknutsen commented 12 years ago

The integration tests are quite slow, is it the ShrinkWrap Resolver usage that cause it ?

jmnarloch commented 12 years ago

Let me test that, if this is the case I would made a fix in the new branch.

jmnarloch commented 12 years ago

I notice one more issue with one of previous PR. I had swapped the package names from org.jboss.arquillian.spring.integration.test.annotation into org.jboss.arquillian.spring.integration.annotation.test, so I would like to correct that. This is simple change, so it won't take long to fix it.

aslakknutsen commented 12 years ago

sure, no problem

jmnarloch commented 12 years ago

Ok, but how I will do that, make a new branch and a pull request?

aslakknutsen commented 12 years ago

sure :)

I'll squash it into this before pushing upstream

aslakknutsen commented 12 years ago

or no new branch needed. just push a new commit to this one

aslakknutsen commented 12 years ago

meaning, add it to the branch where it belongs then push upstream and I can get it from there. (not here as in this pull request unless it belongs here ;)

jmnarloch commented 12 years ago

Ok, I'm done :) (the commit whent to PreAlpha2 branch)

Thanks for help. Have a nice day!

aslakknutsen commented 12 years ago

Thank you, Excellent work!

Have a new weekend :)

aslakknutsen commented 12 years ago

pushed upstream https://github.com/arquillian/arquillian-extension-spring/commit/b6a1a85ee40feb4e4edd59c8050bcb5d8cbe9d23