search

arquillian / arquillian-extension-transaction

9 stars 10 forks source link

Make sure @After runs within transaction bounds #10

Closed papegaaij closed 7 years ago

papegaaij commented 9 years ago

Since 1.1.7, @After is called as part of a TestLifecycleEvent rather then directly from Arquillian. To make sure @After remains within the transaction bounds, TransactionHandler must first proceed and then end the transaction.

bartoszmajsak commented 9 years ago

Thank you for your contribution. There is a problem with this pull request though - with this change in proceeding with the context tests for Persistence Extension are failing when running against 1.1.10.Final. I will leave this for investigation and release in the next version if still feasible.

papegaaij commented 9 years ago

Any news on this issue?

papegaaij commented 8 years ago

@bartoszmajsak what's the progress on this pull request? It's blocking the upgrade to more recent versions for us. Without this change, @After still runs outside the transaction bounds.

bartoszmajsak commented 7 years ago

Better late then never :) Apologies! Thanks for your contribution!

Upstream @92864c82117b9d6e5c70307f81a6ee774bed0c53

bartoszmajsak commented 7 years ago

I've just released 1.0.4 of this extension (note no Final suffix anymore). With good weather it will show up in mvn central on Monday :)

papegaaij commented 7 years ago

Thanks, after 2 years we can finally ditch our custom build 😁

bartoszmajsak commented 7 years ago

giphy 12