search

arquillian / arquillian-governor

Arquillian Governor
Apache License 2.0
10 stars 11 forks source link

Added governor redmine module #18

Closed smiklosovic closed 8 years ago

smiklosovic commented 8 years ago

@rmpestano

I am ready to merge when you are. Please review this once again and let me know.

It is with all your changes + jira and github bugfixes.

Thanks!

rmpestano commented 8 years ago

Hi @smiklosovic,

I think that's it, I will test it after the merge and come back here if something is wrong.

smiklosovic commented 8 years ago

@rmpestano in master

let me know if we can release this

rmpestano commented 8 years ago

Hi @smiklosovic,

it is working great (didn't tested Jira).

There is only one thing in Governor Github which is that it is trying to close closed issues. Do you think it is aproblem? example see last 3 comments of the following issue.

For governor redmine I'm checking if issue isn't closed and then I add the comment.

I can open another PR if you think it is an issue.

smiklosovic commented 8 years ago

closing closed issue is definitely a problem, could you look into that more closely please? it would be awesome if jira was tested as well

i do not have time to deal with this, i can wait ....

rmpestano commented 8 years ago

Sure, I'll look into this. I also will see jira, do we have a public Jira to test governor? otherwise I will install it locally.

smiklosovic commented 8 years ago

no, there is not public jira but that one in issues.jboss.org. I tested it there.