arquillian / arquillian-governor

Arquillian Governor
Apache License 2.0
10 stars 11 forks source link

[closes #23] Add support for class level annotations #25

Closed basovnik closed 8 years ago

basovnik commented 8 years ago
smiklosovic commented 8 years ago

Nice one! Thanks. I like that logic. One thing is that how to handle the situation when jira issue is supposed to be closed when test method has passed but another has failed? What we would really want is to close that issue only in case all test methods with that issue has passed.

so put it in other words, closing of some jira issue would occur somewhere in afterclass only in case number of success test result of some annotation would be equal to number of such methods. And this should be abstracted for every governor annotation.

you could have some class scoped register injected in some aftertest observer and you would set it to true or false. once you have it false you can skip anything else and on aftet class you would actually close it

basovnik commented 8 years ago

The new behaviour is the same as the old one. We can imagine that class annotation is just copied to every method where it is not already. Your request will change the behaviour a little bit. I suppose that two annotations with the same ID in different test classes will be ignored for advanced issue closing. So advanced issue closing will be in test class scope only. My question is should I create new issue for this request or include it to the current pull request?

smiklosovic commented 8 years ago

I would include it in this but as a separate commit on top of this, just dont squash it.

I think that it would just need to be moved to application scope instead of class scope and you would be able to do the same.

basovnik commented 8 years ago

What do you think about the last commit? 83ca5f2df74941ae717d3e703d7204923b15e12c

smiklosovic commented 8 years ago

I will merge it after my remarks. We can after this focus on a multiple jira servers, more or less implemented in my unfinished branch.

smiklosovic commented 8 years ago

good job