search

arquillian / arquillian-governor

Arquillian Governor
Apache License 2.0
10 stars 11 forks source link

[relates #30] Fix maven-checkstyle-plugin configuration #32

Closed basovnik closed 8 years ago

basovnik commented 8 years ago

This change is Reviewable

smiklosovic commented 8 years ago

it is still marked as failed

smiklosovic commented 8 years ago

github tests are failing because we kind of hit some api rate limits, not sure how to repair it, maybe just ignore them or put them to some profile

basovnik commented 8 years ago

There can be only 60 requests per hour [1] when you are unauthorized user. Build succeeded locally on my machine now. One build should take 12 requests (I checked it via X-RateLimit-Remaining HTTP header).

[1] https://developer.github.com/v3/#rate-limiting

smiklosovic commented 8 years ago

so what's the reason it fails when we are using more than 60?

basovnik commented 8 years ago

It works now. I just waited one hour... Could you merge it please?

bartoszmajsak commented 8 years ago

@smiklosovic if you are busy and it's urgent for @basovnik I can take care of it.

bartoszmajsak commented 8 years ago

:)