search

arquillian / arquillian-spacelift

Arquillian process and package manager. Makes executing an external process or fetching platform depends dependencies an easier job
4 stars 7 forks source link

Added SedTool #11

Closed smiklosovic closed 9 years ago

smiklosovic commented 10 years ago

Thanks @TadeasKriz , I merged Tadeas' work on top of my PR so @kpiwko can eventually squash it and merge it to upstream's master when the time comes.

TadeasKriz commented 10 years ago

@smiklosovic @kpiwko I'd rather add more tests. I've made the PR so you guys can look at the API and the implementation and comment on it, but I think it's far from ready for merge.

kpiwko commented 10 years ago

There are issues with this PR:

1/ Using JDK7 related code (StandardCharsets) - please replace with UTF-8 with defaultCharset fallback

2/ Missing documentation of the tools in API - what's input and output of tools and tasks?

3/ Missing documentation in README.md

kpiwko commented 10 years ago

@smiklosovic @TadeasKriz anybody willing to fix that?

smiklosovic commented 10 years ago

@kpiwko

I would leave it on @TadeasKriz since he wrote that.

@TadeasKriz

Once done, please push it to my branch and I push it here as done before so @kpiwko can squash & merge. I would repair JavaDoc, there are classes of which I am the author which is apparently not true. I do not want to earn credit for the code I have not written.

Thanks!

kpiwko commented 10 years ago

@smiklosovic whatever you wish ;-)

TadeasKriz commented 10 years ago

@smiklosovic I extended your code so I'll just put myself as a second author into the javadocs ;)