resolves issues ARQ-1863 and ARQ-1864

[lordofthejars]

resolves issues ARQ-1863 and ARQ-1864 by updating arquillian version to 1.1.5.Final and removing zip4j as dependency and add commons-compress library. Because of this change a new UnzipTool and UntarTool has been implemented, so Linux users that cannot use zip can still uncompress their files.

A base Uncompress class has been created so common uncompress operations for uncompress algorithms can be implemented easier.

[smiklosovic]

I would construct these hello.zip and hello.tgz files dynamically with Shrinkwrap. I think they do not have to be committed to repository at all.

[lordofthejars]

At first I thought exactly the same, but then I thought next case. Now Shrinkwrap supports to export to zip, tar and tgz. But commons-uncompress also implements bz2, z, xz, 7z or arj. Some of them probably won't be used but others like 7z are still in use. So this means that in near future we may implement a 7zTool. So what's happen if we use ShrinkWrap? For zip, tar and tgz no problem, but if we implement 7zTool we will have two kind of tests, ones that uses Shrinkwrap to generate the file to be uncompressed, and another ones that will get an archive from somewhere (probably project itself), so to avoid this in future, I decided to use the most generic and adaptable approach which is having a file there.

Files are really small, so I think it is not so bad, and increases in near future to test every Uncompress tool in the same way.

WDYT?

2014-10-12 19:31 GMT+02:00 Štefan Miklošovič notifications@github.com:

I would construct these hello.zip and hello.tgz files dynamically with Shrinkwrap. I think they do not have to be committed to repository at all.

— Reply to this email directly or view it on GitHub https://github.com/arquillian/arquillian-spacelift/pull/19#issuecomment-58811528 .

+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

[kpiwko]

I don't mind having small archives there. In SWR we have small JARs and WARs there as well...and actually, we even have code to generated them in the project as well.

[lordofthejars]

Yes I know that now as Stefan mentioned, they could be generated using Shrinkwrap, but let's say we want to test password protected zips or any new kind of compress algorithm, then not all tests will follow same approach. For this reason I decided for small archives.

Ok this afternoon I resend the PR fixing the small problems. MongoDB users will love these changes because It will help on automatic MongoDB installation for running tests.

2014-10-13 11:59 GMT+02:00 Karel Piwko notifications@github.com:

I don't mind having small archives there. In SWR we have small JARs and WARs there as well...and actually, we even have code to generated them in the project as well.

— Reply to this email directly or view it on GitHub https://github.com/arquillian/arquillian-spacelift/pull/19#issuecomment-58870934 .

+----------------------------------------------------------+ Alex Soto Bueno - Computer Engineer www.lordofthejars.com +----------------------------------------------------------+

[lordofthejars]

Updated PR with the typo and javadoc fixes, I think it can be merged

[kpiwko]

Thanks @lordofthejars , I'll have a look first thing in the morning tommorow.

[kpiwko]

Pushed upstream in https://github.com/arquillian/arquillian-spacelift/commit/3a2b7aca25376a73ae9d0c1bfd0b79e9965115b3

Thanks!