arquillian / arquillian-spacelift

Arquillian process and package manager. Makes executing an external process or fetching platform depends dependencies an easier job
4 stars 7 forks source link

Wrong parsing of parameters with spaces in it #23

Open smiklosovic opened 9 years ago

smiklosovic commented 9 years ago

@kpiwko Yesterday we found a bug with @TadeasKriz while parsing this thing:

.parameter("--commands=\"deploy something\",\"deploy something2\"")

This goes to jboss-cli.sh like this:

$JBOSS_HOME/bin/jboss-cli.sh --commands="deploy something","deploy something2"

But what Spacelift does is that it puts quotes around it when it founds a space in that string. But in this case, space is a valid character there.

There should be a check that if that space is found between quotes, it will be not taken into consideration.

kpiwko commented 9 years ago

+1