arquillian / arquillian-testcontainers

Arquillian loadable extension for test-container support
Apache License 2.0
5 stars 4 forks source link

Consider removing @DockerRequired #44

Open jasondlee opened 1 week ago

jasondlee commented 1 week ago

The @DockerRequired annotation is likely not needed. The point of this module is to support lifecycle control and injection of Testcontainer instances, so Docker (or Podman) being required is implied. We should be able to remove this annotation, then, and perform any container-readiness checks during the injection handling.

jamezp commented 1 week ago

The one place, and maybe there is a workaround, where the annotation is beneficial is to fail-fast. However, I'm not sure how critical that is.